Fix return of wrong request type on failed updates #6646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -309,7 +309,7 @@ protected ShardIterator shards(ClusterState clusterState, BulkShardRequest reque | |||
| } else { | |||
| logger.debug("[{}][{}] failed to execute bulk item (index) {}", t, shardRequest.request.index(), shardRequest.shardId, indexRequest); | |||
| } | |||
| responses[requestIndex] = new BulkItemResponse(item.id(), indexRequest.opType().lowercase(), | |||
| responses[requestIndex] = new BulkItemResponse(item.id(), "update", | |||
There was a problem hiding this comment.
a bit of nitpicking here: can we use a constant? I see that we use the same string many times in this class. Same could be done for delete and the other string constants as well while we are at it (could be a separate change though)...
There was a problem hiding this comment.
added a second commit with delete and update constants, index is not needed as it is always extracted from the request operation type
|
Left a small comment, LGTM otherwise! |
|
LGTM |
|
LGTM should go into 1.2 too |
In case an update request failed (for example when updating with a wrongly formatted date), the returned index operation type was index instead of update. Closes elastic#6630
in TransportShardBulkAction after fixing an issue.
clintongormley
changed the title
lcawl
added
:Distributed/CRUD
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case an update request failed (for example when updating with a
wrongly formatted date), the returned index operation type was index
instead of update.
Closes #6630