Fail restore if snapshot is corrupted #6938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -107,6 +107,27 @@ public Directory directory() { | |||
| return directory; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns the last committed segments info for the given store | |||
|
LGTM, except for the writeLock comment and taking flush outside of it |
|
LGTM |
1 similar comment
|
LGTM |
today if a snapshot is corrupted the restore operation never terminates. Yet, if the snapshot is corrupted there is no way to restore it anyway. If such a snapshot is restored today the only way to cancle it is to delete the entire index which might cause dataloss. This commit also fixes an issue in InternalEngine where a deadlock can occur if a corruption is detected during flush since the InternalEngine#snapshotIndex aqcuires a topLevel read lock which prevents closing the engine. Closes elastic#6938
s1monw
added a commit
that referenced
this pull request
Jul 21, 2014
today if a snapshot is corrupted the restore operation never terminates. Yet, if the snapshot is corrupted there is no way to restore it anyway. If such a snapshot is restored today the only way to cancle it is to delete the entire index which might cause dataloss. This commit also fixes an issue in InternalEngine where a deadlock can occur if a corruption is detected during flush since the InternalEngine#snapshotIndex aqcuires a topLevel read lock which prevents closing the engine. Closes #6938
s1monw
added a commit
that referenced
this pull request
Jul 21, 2014
today if a snapshot is corrupted the restore operation never terminates. Yet, if the snapshot is corrupted there is no way to restore it anyway. If such a snapshot is restored today the only way to cancle it is to delete the entire index which might cause dataloss. This commit also fixes an issue in InternalEngine where a deadlock can occur if a corruption is detected during flush since the InternalEngine#snapshotIndex aqcuires a topLevel read lock which prevents closing the engine. Closes #6938
clintongormley
added
the
:Distributed/Snapshot/Restore
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
today if a snapshot is corrupted the restore operation never terminates. Yet, if the snapshot is corrupted there is no way to restore it anyway. If such a snapshot is restored today the only way to cancle it is to delete the entire index which might cause dataloss. This commit also fixes an issue in InternalEngine where a deadlock can occur if a corruption is detected during flush since the InternalEngine#snapshotIndex aqcuires a topLevel read lock which prevents closing the engine. Closes elastic#6938
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
today if a snapshot is corrupted the restore operation
never terminates. Yet, if the snapshot is corrupted there
is no way to restore it anyway. If such a snapshot is restored
today the only way to cancle it is to delete the entire index which
might cause dataloss. This commit also fixes an issue in InternalEngine
where a deadlock can occur if a corruption is detected during flush
since the InternalEngine#snapshotIndex aqcuires a topLevel read lock
which prevents closing the engine.