Adds support for wildcards in selected fields #7061
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit simply adds the option to retrieve or generate all possible term vectors of a document, without having to specify a set of selected fields. This could be useful for MLT with items, for example, to provide a nice default if users do not specify any field.
|
The change looks good but I think it would be more consistent with other APIs to accept wildcards in field names than having a |
| @@ -339,7 +339,7 @@ public void writeTo(StreamOutput out) throws IOException { | |||
| public static enum Flag { | |||
| // Do not change the order of these flags we use | |||
| // the ordinal for encoding! Only append to the end! | |||
| Positions, Offsets, Payloads, FieldStatistics, TermStatistics; | |||
| Positions, Offsets, Payloads, FieldStatistics, TermStatistics, GenerateAll; | |||
There was a problem hiding this comment.
Shouldn't be needed anymore?
|
@alexksikes left some comments |
|
LGTM |
alexksikes
added a commit
that referenced
this pull request
Jul 30, 2014
This could useful to generate all term vectors or a chosen set of them. Closes #7061
alexksikes
added a commit
that referenced
this pull request
Sep 8, 2014
This could useful to generate all term vectors or a chosen set of them. Closes #7061
clintongormley
changed the title
alexksikes
changed the title
alexksikes
changed the title
clintongormley
changed the title
clintongormley
added
:Search/Search
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could useful to generate all term vectors or a chosen set of them.