A content decompressor that throws a human readable message when #7241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compression is disabled and the user sends compressed content.
|
LGTM |
|
Merged this to 1.x and master. |
|
A bit late, but if we add the compression handler anyhow now, we might as well enable compression by default and thats it? the potential overhead now exists regardless with the additional handler, right? |
|
Yeah. That's right. BUT: with the changes applied you ALWAYS get a correct HTTP-answer from ES. Before when you disabled compression and sent compressed content you got a cryptic error message. That is why I changed the behavior. |
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
compression is disabled and the user sends compressed content.
This replaces #1678