A content decompressor that throws a human readable message when compression is disabled and the user sends compressed content #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compression is disabled and the user sends compressed content.
|
I looked at it briefly and I think this looks good though. Yet, the indent seems to be off and it seems to use tabs... |
|
Should I create a new pull request? |
|
@derryx it looks like you have deleted your original fork of the elasticsearch repo? in which case yes: please create a new PR. Also, we'll need you to sign the CLA before we can merge it in: http://www.elasticsearch.org/contributor-agreement/ thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the user gets an obscure error message about content that cannot be decoded because ES handles the compressed content as uncompressed content.
I personally think that we should not care about broken clients and respond to requests according to the HTTP specs.
Compression is very useful when you use the bulk-API btw....