Encapsulate AggregationBuilder name and make getter public

[philwills]

As mentioned in https://groups.google.com/forum/?#!msg/elasticsearch/fe9S2mECMEI/57xZK7i6V7MJ, I'd like the name of an AggregationBuilder to be public. I'm attempting to build a wrapper that will provide some type safety around the type of aggregation in the query and the result and not having access to the name is making the API much clunkier than it would otherwise be.

[jpountz]

Hi @philwills, thanks for opening this PR. Maybe there should be a getter (getName) for this property instead of making it public? It would also be nice to make sure this method is used at least somewhere, so maybe we should do the following:

• make name private in AggregationBuilder
• add a getter for name (getName()) in AggregationBuilder
• fix remaining compilation errors by replacing occurrences of name from sub-classes with getName?

Additionally, could you please sign our contributor license agreement?

Thanks!

[philwills]

Thanks for taking a look @jpountz

Personally, I find getters a bit redundant on a final field, but I'm more than happy to go with the house style. I'll try and put something together this evening.

I've now signed the CLA.

[philwills]

Now updated as per your suggestion.

[jpountz]

@philwills Merged, thanks!