Made template filtering generic and extensible #7454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
force-pushed
the
enhancement/index_templates_filtering
branch
from
c309dc0
to
b4081cd
Compare
|
LGTM |
| } else { | ||
| updatedSettingsBuilder.put(entry.getKey(), entry.getValue()); | ||
| if (indexTemplateFilters.isEmpty()) { | ||
| this.indexTemplateFilter = new DefaultIndexTemplateFilter(); |
There was a problem hiding this comment.
the default filter can be static instead of generated?
javanna
force-pushed
the
enhancement/index_templates_filtering
branch
from
b4081cd
to
e031fb7
Compare
…lugins Added the ability to register template filters that are being applied when a new index is created. The default filter that checks whether the template pattern matches the index name always runs first, additional filters can also be registered so that templates can be filtered out based on custom logic. Took the chance to add the handy source(Object... source) method to PutIndexTemplateRequest and corresponding builder Closes elastic#7459 Closes elastic#7454
javanna
force-pushed
the
enhancement/index_templates_filtering
branch
from
e031fb7
to
92ae3c8
Compare
javanna
added a commit
that referenced
this pull request
Aug 27, 2014
…lugins Added the ability to register template filters that are being applied when a new index is created. The default filter that checks whether the template pattern matches the index name always runs first, additional filters can also be registered so that templates can be filtered out based on custom logic. Took the chance to add the handy source(Object... source) method to PutIndexTemplateRequest and corresponding builder Closes #7459 Closes #7454
javanna
added a commit
that referenced
this pull request
Sep 8, 2014
…lugins Added the ability to register template filters that are being applied when a new index is created. The default filter that checks whether the template pattern matches the index name always runs first, additional filters can also be registered so that templates can be filtered out based on custom logic. Took the chance to add the handy source(Object... source) method to PutIndexTemplateRequest and corresponding builder Closes #7459 Closes #7454
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
:Data Management/Indices APIs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to register index template filters that are being applied when a new index is created, in order to decide whether a matching index template should be applied or not. The default filter that checks whether the template pattern matches the index name always runs first, additional filters can also be registered so that templates can be filtered out based on custom logic.
Took the chance to add the handy
source(Object... source)method toPutIndexTemplateRequestand corresponding builder.Closes #7459