Add mocking framework?

[cfontes]

Hi,

I am new, and maybe it's just my lack of knowledge.

But wouldn't it be easier to create unit tests with a mocking framework like easymock or mockito.

I am trying to test this parse function, for #7408.

public class FieldValueFactorFunctionParser implements ScoreFunctionParser {
    public static String[] NAMES = { "field_value_factor", "fieldValueFactor" };

    @Override
    public ScoreFunction parse(QueryParseContext parseContext, XContentParser parser) throws IOException, QueryParsingException {

But to do that I need to create a valid QueryParseContext and also a XContentParser. The mock would allow me to focus on the method logic instead of spending time trying to figure out how to get those 2 objects, which I don't care very much about at this point in time (maybe after in the dev I will. But not right now at the start of my wanna be task).

[s1monw]

We discussed this and came to the conclusion that this is mainly addressed with ElasticsearchSingleNodeTest.java in the test framework. The majority of us are in favor of not adding a mock framework for several reasons mainly related to the mess they tend to create. I am closing this as won't fix

[cfontes]

Thanks for the answer!