Don't update indexShard if it has been removed before #7509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -548,11 +549,13 @@ private void applyNewOrUpdatedShards(final ClusterChangedEvent event) throws Ela | |||
| // if the current and global routing are initializing, but are still not the same, its a different "shard" being allocated | |||
| // for example: a shard that recovers from one node and now needs to recover to another node, | |||
| // or a replica allocated and then allocating a primary because the primary failed on another node | |||
| boolean shardHashBeenRemoved = false; | |||
There was a problem hiding this comment.
Typo.. shardHas_h_BeenRemoved.
|
LGTM. Nice catch |
s1monw
force-pushed
the
fix_random_exceptions
branch
from
4cb24b4
to
400f1c8
Compare
Today we have logic that removes a shard from the indexservice if the shard has changed ie. from replica to primary or if it's recovery source vanished etc. This can cause shards from been not allocated at all on a nodes causeing delete requests to timeout since we were waiting for shards on nodes that got dropped due to a IndexShardMissingException Closes elastic#7509
s1monw
force-pushed
the
fix_random_exceptions
branch
from
400f1c8
to
1bb0677
Compare
s1monw
added a commit
that referenced
this pull request
Aug 29, 2014
Today we have logic that removes a shard from the indexservice if the shard has changed ie. from replica to primary or if it's recovery source vanished etc. This can cause shards from been not allocated at all on a nodes causeing delete requests to timeout since we were waiting for shards on nodes that got dropped due to a IndexShardMissingException Closes #7509
s1monw
added a commit
that referenced
this pull request
Sep 8, 2014
Today we have logic that removes a shard from the indexservice if the shard has changed ie. from replica to primary or if it's recovery source vanished etc. This can cause shards from been not allocated at all on a nodes causeing delete requests to timeout since we were waiting for shards on nodes that got dropped due to a IndexShardMissingException Closes #7509
clintongormley
changed the title
clintongormley
changed the title
clintongormley
added
the
:Distributed/Recovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we have logic that removes a shard from the indexservice if
the shard has changed ie. from replica to primary or if it's recovery
source vanished etc. This can cause shards from been not allocated at
all on a nodes causeing delete requests to timeout since we were waiting
for shards on nodes that got dropped due to a IndexShardMissingException
you'd see exceptions like this before: