Mark transport client as such when instantiating #7552
Conversation
| TransportClient client = (TransportClient) internalCluster().client(); | ||
| Settings settings = client.injector.getInstance(Settings.class); | ||
| assertThat(settings.getAsBoolean("transport.client", false), is(true)); | ||
| } |
There was a problem hiding this comment.
maybe add another test the verify that this setting cannot be overridden (so basically, create a transport client with custom setting that sets the transport.client to false and verify that it's still true)?
There was a problem hiding this comment.
Also what happens if we set transport.client to true manually within a node client?
There was a problem hiding this comment.
@javanna very good point... maybe the setting should change to client.type with either transport or node as values, and then we force set this on both the transport client and internal node?
There was a problem hiding this comment.
valid point.. will change that
|
Ha great! I think @bleskes will like it as well :) |
spinscale
force-pushed
the
enhancement/transport-client-set-settings
branch
from
1e111f1
to
cd5cabd
Compare
|
nice @spinscale I like it! |
|
Could we add a static final String for "transport" and "node" values? |
spinscale
force-pushed
the
enhancement/transport-client-set-settings
branch
from
cd5cabd
to
d5e91dc
Compare
|
@uboness moved into the check into |
|
LGTM |
This allows plugins to load/inject specific classes, when the client started is a transport client (compared to being a node client). Closes elastic#7552
spinscale
force-pushed
the
enhancement/transport-client-set-settings
branch
from
6f6144b
to
8b8cc80
Compare
This allows plugins to load/inject specific classes, when the client started is a transport client (compared to being a node client). Closes #7552
This allows plugins to load/inject specific classes, when the client started is a transport client (compared to being a node client). Closes #7552
clintongormley
changed the title
This allows plugins to load/inject specific classes, when the client started
is a transport client (compared to being a node client).