Refactor copy headers mechanism in REST API #7594
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
force-pushed
the
enhancement/rest_client_factory
branch
from
33c28e4
to
e9f961e
Compare
| * Returns a proper {@link Client client} given the provided {@link org.elasticsearch.rest.RestRequest} | ||
| */ | ||
| public Client client(RestRequest restRequest) { | ||
| return usefulHeaders.size() == 0 ? client : new HeadersCopyClient(client, restRequest, usefulHeaders); |
|
I left some minor comments |
clintongormley
changed the title
The functionality of copying headers in the REST layer (from REST requests to transport requests) remains the same. Made it a bit nicer by introducing a ClientFactory component that is a singleton and allows to register useful headers without requiring static methods. Plugins just have to inject the ClientFactory now, and call its `addUsefulHeaders` method that is not static anymore. Relates to elastic#6513 Closes elastic#7594
javanna
force-pushed
the
enhancement/rest_client_factory
branch
from
e9f961e
to
2d399ef
Compare
|
I pushed a new commit that addresses the naming feedback. I also rebased to adapt the code to #7610 that was pushed in the meantime. |
|
LGTM |
javanna
added a commit
that referenced
this pull request
Sep 10, 2014
The functionality of copying headers in the REST layer (from REST requests to transport requests) remains the same. Made it a bit nicer by introducing a RestClientFactory component that is a singleton and allows to register useful headers without requiring static methods. Plugins just have to inject the RestClientFactory now, and call its `addRelevantHeaders` method that is not static anymore. Relates to #6513 Closes #7594
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 11, 2014
…tory With elastic#7594 we replaced the static `BaseRestHandler#addUsefulHeaders` by introducing the `RestClientFactory` that can be injected and used to register the relevant headers. To simplify things, we can now register relevant headers through the `RestController` and remove the `RestClientFactory` that was just introduced. Closes elastic#7675
javanna
added a commit
that referenced
this pull request
Sep 11, 2014
…tory With #7594 we replaced the static `BaseRestHandler#addUsefulHeaders` by introducing the `RestClientFactory` that can be injected and used to register the relevant headers. To simplify things, we can now register relevant headers through the `RestController` and remove the `RestClientFactory` that was just introduced. Closes #7675
javanna
added a commit
that referenced
this pull request
Sep 11, 2014
…tory With #7594 we replaced the static `BaseRestHandler#addUsefulHeaders` by introducing the `RestClientFactory` that can be injected and used to register the relevant headers. To simplify things, we can now register relevant headers through the `RestController` and remove the `RestClientFactory` that was just introduced. Closes #7675
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The functionality of copying headers in the REST layer (from REST requests to transport requests) remains the same. Made it a bit nicer by introducing a ClientFactory component that is a singleton and allows to register useful headers without requiring static methods.
Plugins just have to inject the ClientFactory now, and call its
addUsefulHeadersmethod that is not static anymore.Relates to #6513