Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add explicit error when PUT mapping API is given an empty request body. #7618

Closed
wants to merge 1 commit into from
Closed

Add explicit error when PUT mapping API is given an empty request body. #7618

wants to merge 1 commit into from

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Sep 5, 2014

I also added validation for an empty type, and added tests (just for validation for now).

closes #7536

@s1monw
Copy link
Contributor

s1monw commented Sep 5, 2014

LGTM

@rjernst rjernst closed this in 669a7eb Sep 5, 2014
rjernst added a commit that referenced this pull request Sep 5, 2014
@rjernst
RestAPI: Add explicit error when PUT mapping API is given an empty re…
e24d85e 
…quest body.

closes #7536
closes #7618
rjernst added a commit that referenced this pull request Sep 8, 2014
@rjernst @areek
RestAPI: Add explicit error when PUT mapping API is given an empty re…
58bd3a6 
…quest body.

closes #7536
closes #7618
@clintongormley clintongormley changed the title RestAPI: Add explicit error when PUT mapping API is given an empty request body. Mapping: Add explicit error when PUT mapping API is given an empty request body. Sep 8, 2014
@rjernst rjernst mentioned this pull request Oct 31, 2014
Closed
@rjernst rjernst deleted the fix/7536 branch January 21, 2015 23:22
@clintongormley clintongormley added the :Search/Mapping Index mappings, including merging and defining field types label Jun 7, 2015
@clintongormley clintongormley changed the title Mapping: Add explicit error when PUT mapping API is given an empty request body. Add explicit error when PUT mapping API is given an empty request body. Jun 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
>bug :Search/Mapping Index mappings, including merging and defining field types v1.4.0.Beta1 v2.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Putting a mapping with an empty request body throws a NullPointerException
3 participants
@rjernst @s1monw @clintongormley