Support for arrays of numeric values in include/exclude clauses #7727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -46,13 +48,16 @@ | |||
| protected final LongHash bucketOrds; | |||
| private boolean showTermDocCountError; | |||
| private SortedNumericDocValues values; | |||
| private IncludeExclude includeExclude; | |||
| private LongFilter longFilter; | |||
There was a problem hiding this comment.
unused field, maybe remove it?
|
Left a minor comment, other than that LGTM |
|
Thanks for the review, @martijnvg |
|
Pushed as 4f69a98 |
markharwood
referenced
this pull request
Dec 4, 2014
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed terms and significant_terms aggregation to allow include/exclude values which are numerics.
Internally the IncludeExclude class now has a convertToLong/DoubleFilter method to convert the string representation of user criteria into a class with sets of primitive numerics used for fast evaluation of filters.
Closes #7714