Chunk direct buffer usage by networking layer #7811
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimchy
added
>enhancement
v1.3.3
v1.4.0.Beta1
v2.0.0-beta1
v1.5.0
blocker
review
labels
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent). This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM. This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages. See the doc on NettyUtils#DEFAULT_GATHERING for more info. closes elastic#7811
kimchy
force-pushed
the
netty_gathering
branch
from
88914ec
to
ecf8cee
Compare
| * <p/> | ||
| * Note, on the read size of netty, it uses a single direct buffer that is defined in both the transport | ||
| * and http configuration (based on the direct memory available), and the upstream handlers (SizeHeaderFrameDecoder, | ||
| * or more specifically the FrameDecoder base class) makes sure to use a cumolation buffer and not copy it |
There was a problem hiding this comment.
its actually named cumulation buffer in netty, will do the s/o/u
| @@ -53,25 +95,12 @@ public InternalLogger newInstance(String name) { | |||
| }); | |||
|
|
|||
| ThreadRenamingRunnable.setThreadNameDeterminer(ES_THREAD_NAME_DETERMINER); | |||
|
|
|||
| DEFAULT_GATHERING = Booleans.parseBoolean(System.getProperty("es.netty.gathering"), true); | |||
There was a problem hiding this comment.
any chance we can randomize this?
|
I left some comments but in general LGTM |
|
LGTM - ran tests on java 8 and java 7 +1 to push |
kimchy
added a commit
that referenced
this pull request
Sep 23, 2014
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent). This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM. This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages. See the doc on NettyUtils#DEFAULT_GATHERING for more info. closes #7811
kimchy
added a commit
that referenced
this pull request
Sep 23, 2014
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent). This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM. This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages. See the doc on NettyUtils#DEFAULT_GATHERING for more info. closes #7811
kimchy
added a commit
that referenced
this pull request
Sep 23, 2014
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent). This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM. This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages. See the doc on NettyUtils#DEFAULT_GATHERING for more info. closes #7811
clintongormley
changed the title
Closed
clintongormley
added
the
:Distributed/Network
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent). This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM. This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages. See the doc on NettyUtils#DEFAULT_GATHERING for more info. closes elastic#7811
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent). This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM. This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages. See the doc on NettyUtils#DEFAULT_GATHERING for more info. closes elastic#7811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today, due to how netty works (both on http layer and transport layer), and even though the buffers sent over to netty are paged (CompositeChannelBuffer), it ends up re-copying the whole buffer into another heap buffer (bad), and then send it over directly to sun.nio which allocates a full thread local direct buffer to send it (which can be repeated if not all message is sent).
This is problematic for very large messages, aside from the extra heap temporal usage, the large direct buffers will stay around and not released by the JVM.
This change forces the use of gathering when building a CompositeChannelBuffer, which results in netty using the sun.nio write method that accepts an array of ByteBuffer (so no extra heap copying), and also reduces the amount of direct memory allocated for large messages.
See the doc on NettyUtils#DEFAULT_GATHERING for more info.