Add total index memory in _cat/indices
#7824
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * FieldData, IdCache, Percolate, Segments (memory, index writer, version map) | ||
| */ | ||
| public ByteSizeValue getTotalMemory() { | ||
| long size = this.getFieldData().getMemorySizeInBytes() + |
There was a problem hiding this comment.
not sure though but are they all guaranteed to be non-null?
|
I like it - left one comment |
|
@s1monw PR updated based on your comment. Indeed, I thought those values can not be null but it's safer to protect that. |
|
LGTM |
This patch adds to `_cat/indices` information about memory usage per index by adding memory used by FieldData, IdCache, Percolate, Segments (memory, index writer, version map). ``` % curl 'localhost:9200/_cat/indices?v&h=i,tm' i tm wiki 8.1gb test 30.5kb user 1.9mb ``` Closes elastic#7008
dadoonet
force-pushed
the
pr/7008-cat-index-memory
branch
from
08c74a6
to
c62730c
Compare
clintongormley
added
>enhancement
v2.0.0-beta1
v1.5.0
:Data Management/CAT APIs
clintongormley
changed the title
_cat/indices_cat/indices
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds to
_cat/indicesinformation about memory usage per index by adding memory used by FieldData, IdCache, Percolate, Segments (memory, index writer, version map).Closes #7008