During recovery, mark last file chunk to fail fast if payload is truncated #7830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Good catch. |
Today we rely on the metadata length of the file we are recoverying to indicate when the last chunk was received. Yet, this might hide bugs on the compression layer if payloads are truncated. We should indicate if the last chunk is send to make sure we validate checksums accordingly if possible. Closes elastic#7830
s1monw
added a commit
that referenced
this pull request
Sep 23, 2014
Today we rely on the metadata length of the file we are recoverying to indicate when the last chunk was received. Yet, this might hide bugs on the compression layer if payloads are truncated. We should indicate if the last chunk is send to make sure we validate checksums accordingly if possible. Closes #7830
s1monw
added a commit
that referenced
this pull request
Sep 23, 2014
Today we rely on the metadata length of the file we are recoverying to indicate when the last chunk was received. Yet, this might hide bugs on the compression layer if payloads are truncated. We should indicate if the last chunk is send to make sure we validate checksums accordingly if possible. Closes #7830
clintongormley
changed the title
clintongormley
added
the
:Distributed/Recovery
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Today we rely on the metadata length of the file we are recoverying to indicate when the last chunk was received. Yet, this might hide bugs on the compression layer if payloads are truncated. We should indicate if the last chunk is send to make sure we validate checksums accordingly if possible. Closes elastic#7830
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This test sometimes corrupts a file by truncating a chunk on the network layer. Yet this was not detected and required changes in the wire protocol. It's fixed in 1.4 see elastic#7830 for details Relates to elastic#7830
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today we rely on the metadata length of the file we are recoverying
to indicate when the last chunk was received. Yet, this might hide bugs
on the compression layer if payloads are truncated. We should indicate
if the last chunk is send to make sure we validate checksums
accordingly if possible.