[TEST] create client nodes using node.client: true #7911
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… false and node.master: false
| @@ -1458,7 +1458,7 @@ private void removeDisruptionSchemeFromNode(NodeAndClient nodeAndClient) { | |||
| private static final class DataNodePredicate implements Predicate<NodeAndClient> { | |||
| @Override | |||
| public boolean apply(NodeAndClient nodeAndClient) { | |||
| return nodeAndClient.node.settings().getAsBoolean("node.data", true); | |||
| return nodeAndClient.node.settings().getAsBoolean("node.data", true) && !nodeAndClient.node.settings().getAsBoolean("node.client", false); | |||
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 29, 2014
… false and node.master: false Create client nodes using `node.client: true` instead of `node.data: false` and `node.master: false`. We should create client nodes in our test infra using the `node.client:true` settings as that is the one that users use, and the one that we use as well in `ClientNodePredicate` thus we end up not finding client nodes otherwise as they weren't created with the proper setting. Updated also the `DataNodePredicate` so that `client: true` is enough, no need for `data: false` as well. Closes elastic#7911
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Sep 29, 2014
… false and node.master: false Create client nodes using `node.client: true` instead of `node.data: false` and `node.master: false`. We should create client nodes in our test infra using the `node.client:true` settings as that is the one that users use, and the one that we use as well in `ClientNodePredicate` thus we end up not finding client nodes otherwise as they weren't created with the proper setting. Updated also the `DataNodePredicate` so that `client: true` is enough, no need for `data: false` as well. Closes elastic#7911
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
… false and node.master: false Create client nodes using `node.client: true` instead of `node.data: false` and `node.master: false`. We should create client nodes in our test infra using the `node.client:true` settings as that is the one that users use, and the one that we use as well in `ClientNodePredicate` thus we end up not finding client nodes otherwise as they weren't created with the proper setting. Updated also the `DataNodePredicate` so that `client: true` is enough, no need for `data: false` as well. Closes elastic#7911
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create client nodes using
node.client: trueinstead ofnode.data: falseandnode.master: false.We should create client nodes in our test infra using the
node.client:truesettings as that is the one that users use, and the one that we use as well inClientNodePredicatethus we end up not finding client nodes otherwise as they weren't created with the proper setting.Updated also the
DataNodePredicateso thatclient: trueis enough, no need fordata: falseas well.