Fixing SearchRequestBuilder aggregations call to facets #8121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is already fixed in master thanks to the removal of facets.
|
LGTM Since this issue has not been noticed before, I'm wondering if we should just remove it in 2.0. |
|
It does seem like an oddly complex version of the method. I would be pretty stunned if people were submitting their aggregations in bytes to the builder at all. |
pickypg
added a commit
that referenced
this pull request
Oct 16, 2014
…ation-not-facet Fixing SearchRequestBuilder aggregations call to facets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is already fixed in master thanks to the removal of facets.
Closes #8120