Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Groovy jar - Use Java 7 version #8182

Closed
pickypg opened this issue Oct 21, 2014 · 3 comments · Fixed by #8183
Closed

Groovy jar - Use Java 7 version #8182

pickypg opened this issue Oct 21, 2014 · 3 comments · Fixed by #8183

Comments

@pickypg
Copy link
Member

pickypg commented Oct 21, 2014

Now that we require Java 7, we can get invokedynamic benefits by using the Java 7 version of Groovy 2.x.

The change requires using a different Groovy jar geared specifically for Java 7. It's important to note their warning (taken verbatim from the above link):

All JDK 7 versions ranging from 7u21 to 7u55 are buggy with regards to invokedynamic. If you plan to use invokedynamic support, make sure you either use 7u60 or JDK 8.

This should help to speed up scripting support without any effort.

Thanks to Robert and Uwe for pointing it out.

@nik9000
Copy link
Member

nik9000 commented Oct 21, 2014

This would scratch 7u25 from the list of viable Java versions for Elasticsearch I think. Probably worth thinking about.

@rmuir
Copy link
Contributor

rmuir commented Oct 21, 2014

7u25 is pretty ancient, the jre technically "expired" over a year ago. The change should go in 2.0 for sure.

@s1monw
Copy link
Contributor

s1monw commented Oct 21, 2014

+1 for going for a newer JVM here I think the benefits are worth it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants