Introduce a RefCounted interface and basic impl #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bleskes all yours... ;) |
| @Override | ||
| public final void incRef() { | ||
| if (tryIncRef() == false) { | ||
| throw new AlreadyClosedException("Store is already closed can't increment refCount current count [" + refCount.get() + "]"); |
There was a problem hiding this comment.
We should remove the Store part. Perhaps make a constructor with a name? these errors are difficult tot trace so we should make it as clear as possible where the error came from (even if the stack trace is lost)
There was a problem hiding this comment.
that is a copy / paste error I will fix
|
LGTM. I like the abstract class + interface approach. Left two little comments. |
|
@bleskes pushed a new commit |
|
@s1monw looks great. |
We already have two places duplicating this rather hairy logic, this commit intorduces a new RefCoutned interace and an abstract implementation that can be used for delegation. It factors out all the reference counting and adds single and multithreaded test for it. Closes elastic#8210
s1monw
added a commit
that referenced
this pull request
Oct 24, 2014
We already have two places duplicating this rather hairy logic, this commit intorduces a new RefCoutned interace and an abstract implementation that can be used for delegation. It factors out all the reference counting and adds single and multithreaded test for it. Closes #8210
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already have two places duplicating this rather hairy logic, this
commit intorduces a new RefCoutned interace and an abstract implementation
that can be used for delegation. It factors out all the reference counting
and adds single and multithreaded test for it.