Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve #8237

Closed
costin opened this issue Oct 27, 2014 · 1 comment
Closed

Improve #8237

costin opened this issue Oct 27, 2014 · 1 comment
Assignees
Labels
:Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts good first issue low hanging fruit Team:Delivery Meta label for Delivery team v1.3.5 v1.4.0 v1.5.0 v2.0.0-beta1

Comments

@costin
Copy link
Member

costin commented Oct 27, 2014

Currently service.bat and elasticsearch.bat duplicate the code required to trigger the variable and classpath initialization on windows. In a similar vein to elasticsearch.in.sh, a common file between the two would simplify the maintenance of the two going forward.

@costin costin added good first issue low hanging fruit :Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts v1.4.0 labels Oct 27, 2014
@costin costin self-assigned this Oct 27, 2014
costin added a commit to costin/elasticsearch that referenced this issue Oct 27, 2014
Break-out common functionality between elasticsearch.bat and service.bat
Relates elastic#8237
costin added a commit that referenced this issue Oct 28, 2014
Break-out common functionality between elasticsearch.bat and service.bat
Relates #8237
costin added a commit that referenced this issue Oct 28, 2014
Break-out common functionality between elasticsearch.bat and service.bat
Relates #8237

(cherry picked from commit 87095e7)
costin added a commit that referenced this issue Oct 28, 2014
Break-out common functionality between elasticsearch.bat and service.bat
Relates #8237

(cherry picked from commit 87095e7)
costin added a commit that referenced this issue Oct 28, 2014
Synchronize the .bat files with the .sh ones by adding ES_USE_IPV4
flag. Higher branches (from 1.4 included) extend this functionality by
introducing elasticsearch.in.bat to mirror elasticsearch.in for *nix
systems.

Relates #8237
@costin
Copy link
Member Author

costin commented Oct 28, 2014

Fixed in 1.3, 1.4, 1.x and master. See #8244 PR for more information.

@costin costin closed this as completed Oct 28, 2014
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Break-out common functionality between elasticsearch.bat and service.bat
Relates elastic#8237

(cherry picked from commit 87095e7)
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Synchronize the .bat files with the .sh ones by adding ES_USE_IPV4
flag. Higher branches (from 1.4 included) extend this functionality by
introducing elasticsearch.in.bat to mirror elasticsearch.in for *nix
systems.

Relates elastic#8237
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Delivery/Build Build or test infrastructure :Delivery/Packaging RPM and deb packaging, tar and zip archives, shell and batch scripts good first issue low hanging fruit Team:Delivery Meta label for Delivery team v1.3.5 v1.4.0 v1.5.0 v2.0.0-beta1
Projects
None yet
Development

No branches or pull requests

2 participants