Allow to configure custom thread pools #8247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertThat(info1.getMin(), equalTo(1)); | ||
| assertThat(info1.getMax(), equalTo(1)); | ||
| assertThat(info1.getQueueSize().singles(), equalTo(1l)); | ||
| } |
There was a problem hiding this comment.
Should we not fail the test if we get a name thats not either "my_pool1" or "my_pool2"?
There was a problem hiding this comment.
Make sense. I'll update that.
|
@martijnvg left a couple of comments |
martijnvg
force-pushed
the
improvements/custom_thread_pool
branch
from
6fef669
to
1f37ca8
Compare
|
@colings86 Thanks for looking at this! I updated the PR and applied your feedback. |
|
LGTM |
martijnvg
force-pushed
the
improvements/custom_thread_pool
branch
from
1f37ca8
to
7761154
Compare
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Oct 31, 2014
martijnvg
added a commit
that referenced
this pull request
Oct 31, 2014
clintongormley
changed the title
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.