New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make template params take arrays #8255
Make template params take arrays #8255
Conversation
…so that it can take more data-types than just strings, to support Arrays.
fb2cc29
to
d601ba6
Compare
@GaelTadh Can you review please? |
Hi @reuben-sutton. Thanks for the PR. We'll take a look and get back to you. Meanwhile, could I ask you to sign the CLA please: http://www.elasticsearch.org/contributor-agreement/ thanks |
Thanks @clintongormley - signed. |
Thanks @reuben-sutton I'll take a look. |
Hey @GaelTadh, is there anything I can do to move this forward - would quite like to be able to get rid of the hack in my code for working round it. Thanks, |
@reuben-sutton I will get to this today or tomorrow at the latest. |
Hi @reuben-sutton - I'm afraid you've signed the CLA with a different email address than the the one you've used on GitHub, so we can't be "sure" that you're the same person :) Sorry for the ask, but please could you sign again: http://www.elasticsearch.org/contributor-agreement/ thanks |
Hi @clintongormley - Sorry about that, I've signed with my other email too now. Thanks, |
thanks @reuben-sutton - that worked :) |
Hi @GaelTadh, do you mind if I bump this again? |
I will be looking at this again today |
This LGTM, @dakrone is going to take a quick look before I merge it in. |
LGTM too! |
This has been merged to master and 1.x |
Great, is this going to be available only from |
As it's not a bug fix I haven't ported it to 1.4 or 1.3. @clintongormley what do you think ? |
no don't port it |
Someone also hit also this issue: https://groups.google.com/d/msgid/elasticsearch/27cafc64-d21b-4fec-8273-3f92ef92ad8f%40googlegroups.com?utm_medium=email&utm_source=footer I think it's actually a bug in Java API as explained by @reuben-sutton. I'd be +1 to backport it at least in 1.4 |
has this been ported to 1.4? else please advise what are my options to use java api for query like below where only query: "XXXX", "YYYY", "ZZZZ" change between different search requests . GET /cobalt-vehicles/vehicles/_search |
Currently the templateParams in SearchRequest is a
Map<String, String>
- this means that it could not take Arrays as part of the parameters, which is not the case when accessing it through the REST api, and also as documented in the docs for this feature.This changes it to
Map<String, Object>
so that it can take other data-types.