Use a 1024 byte minimum weight for filter cache entries #8304
Conversation
|
I also manually tested this, where I ran a shell script containing non-existing term filters over the wikipedia corpus, I was able to see: "filter_cache" : {
"memory_size" : "396.2kb",
"memory_size_in_bytes" : 405760,
"evictions" : 55018
}to show that filter cache entries are being evicted even though the size limit has not been reached due to the minimum size. |
| @@ -145,6 +154,7 @@ public void addReaderKeyToClean(Object readerKey) { | |||
| public void close() { | |||
| closed = true; | |||
| cache.invalidateAll(); | |||
| cache.cleanUp(); | |||
There was a problem hiding this comment.
Is it needed because of this change or is it unrelated?
There was a problem hiding this comment.
Not needed, but always good to actually clean the cache when closing, happy to remove it if you'd like
There was a problem hiding this comment.
I was just wondering if there could be bad side-effects such as causing some operations to take longer.
There was a problem hiding this comment.
There aren't any bad side-effects, without this, if the cache were closed and everything was invalidated, they would not be immediately removed, this just immediately removes them.
|
LGTM |
This changes the weighing function for the filter cache to use a configurable minimum weight for each filter cached. This value defaults to 1kb and can be configured with the `indices.cache.filter.minimum_entry_weight` setting. This also fixes an issue with the filter cache where the concurrency level of the cache was exposed as a setting, but not used in cache construction. Relates to elastic#8268
dakrone
force-pushed
the
bound-filter-cache-size
branch
from
d2e1493
to
42b6e01
Compare
clintongormley
changed the title
clintongormley
changed the title
This changes the weighing function for the filter cache to use a
configurable minimum weight for each filter cached. This value defaults
to 1kb and can be configured with the
indices.cache.filter.minimum_entry_weightsetting.This also fixes an issue with the filter cache where the concurrency
level of the cache was exposed as a setting, but not used in cache
construction.
Relates to #8268
Fixes #8249