Don't accept a dynamic update to min_master_nodes which is larger then current master node count
#8321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… larger then current master node count The discovery.zen.minimum_master_nodes setting can be updated dynamically. Settings it to a value higher then the current number of master nodes will cause the current master to step down. This is dangerous because if done by mistake (typo) there is no way to restore the settings (this requires an active master).
|
|
||
| @Test | ||
| public void testCanNotBringClusterDown() throws ExecutionException, InterruptedException { | ||
| int nodeCount = scaledRandomIntBetween(1, 1); |
There was a problem hiding this comment.
Maybe the max should be more? Something like 5
There was a problem hiding this comment.
I had commit on my machine I forget to push changing this back to it's original value - 10
|
@bleskes This looks good. I left two questions / comments. |
bleskes
force-pushed
the
min_master_nodes_validation
branch
from
ad4ed9c
to
31c2f55
Compare
|
@martijnvg thx. responded. |
|
@bleskes LGTM |
bleskes
added a commit
that referenced
this pull request
Nov 3, 2014
… larger then current master node count The discovery.zen.minimum_master_nodes setting can be updated dynamically. Settings it to a value higher then the current number of master nodes will cause the current master to step down. This is dangerous because if done by mistake (typo) there is no way to restore the settings (this requires an active master). Closes #8321
clintongormley
added
the
:Distributed/Discovery-Plugins
clintongormley
changed the title
min_master_nodes which is larger then current master node count
clintongormley
added
:Core/Infra/Settings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The discovery.zen.minimum_master_nodes setting can be updated dynamically. Settings it to a value higher then the current number of master nodes will cause the current master to step down. This is dangerous because if done by mistake (typo) there is no way to restore the settings (this requires an active master).