Keep the last legacy checksums file at the end of restore #8358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Distributed/Snapshot/Restore
| @@ -638,6 +638,24 @@ public MetadataSnapshot(Map<String, StoreFileMetaData> metadata) { | |||
| } | |||
| } | |||
|
|
|||
| static void cleanLegacyChecksums(Directory directory, long newVersion) throws IOException { | |||
There was a problem hiding this comment.
can we have a quick javadoc comment what this method does? Not related but I think we should maybe move all these legacy checksum related stuff in it's own inner class and only sync on that class instead of the directory etc.
|
left some comments - good catch btw. |
|
I guess this should go into |
|
@s1monw, I pushed the updated version. Yes, I think it makes sense to push to 1.3.6 as well if we will release it. |
|
LGTM |
…estore This commit fixes the issue caused by restore process deleting all legacy checksum files at the end of restore process. Instead it keeps the latest version of the checksum intact. The issue manifests itself in losing checksum for all legacy files restored into post 1.3.0 cluster, which in turn causes unnecessary snapshotting of files that didn't change. Fixes elastic#8119
imotov
force-pushed
the
issue-8119-legacy-checksum-not-restored
branch
from
4e90785
to
fd8a56d
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue caused by restore process deleting all legacy checksum files at the end of restore process. Instead it keeps the latest version of the checksum intact. The issue manifests itself in losing checksum for all legacy files restored into post 1.3.0 cluster, which in turn causes unnecessary snapshotting of files that didn't change.
Fixes #8119