Fix GET index API always running all features #8392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colings86
added
:Analytics/Aggregations
| } | ||
| if (settings != null) { | ||
| this.settings = settings; | ||
| } |
There was a problem hiding this comment.
what happens if we assign to null? wondering why these checks are needed
There was a problem hiding this comment.
To be backwards compatible we need to return empty objects rather than null for features that return null from the request
|
@javanna have pushed a new iteration. Let me know what you think |
| @@ -43,7 +111,15 @@ public GetIndexRequest features(String[] features) { | |||
| return this; | |||
| } | |||
|
|
|||
| public String[] features() { | |||
There was a problem hiding this comment.
I think we should leave this method for java api bw comp
|
LGTM |
Previous to this change all features (_alias,_mapping,_settings,_warmer) are run regardless of which features are actually requested. This change fixes the request object to resolve this bug
|
merged into master, for 1.x and 1.4 changes see https://github.com/elasticsearch/elasticsearch/pull/8452/files |
clintongormley
added
the
:Data Management/Indices APIs
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change all features (_alias,_mapping,_settings,_warmer) are run regardless of which features are actually requested. This change fixes the request object to resolve this bug