Restore with wait_for_completion:true should wait for succesfully restored shards to get started
#8545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Distributed/Snapshot/Restore
| // Shard disappeared (index deleted) or became active | ||
| if (shardRouting == null || shardRouting.active()) { | ||
| iterator.remove(); | ||
| logger.debug("[{}][{}] shard started - removing", request.snapshotId(), shardId); |
There was a problem hiding this comment.
shard started is misleading if shardRouting == null.
|
Left some minor comments. LGTM |
s1monw
changed the title
| @@ -76,25 +75,26 @@ protected void masterOperation(final RestoreSnapshotRequest request, ClusterStat | |||
| request.indices(), request.indicesOptions(), request.renamePattern(), request.renameReplacement(), | |||
| request.settings(), request.masterNodeTimeout(), request.includeGlobalState(), request.partial(), request.includeAliases()); | |||
|
|
|||
| restoreService.restoreSnapshot(restoreRequest, new RestoreSnapshotListener() { | |||
| restoreService.restoreSnapshot(restoreRequest, new ActionListener<RestoreInfo>() { | |||
There was a problem hiding this comment.
unrelated but I think we should use DelegatingActionListener here
There was a problem hiding this comment.
Hmm, I don't see how this is going to be useful delegated listener is not called every time and DelegatingActionListener doesn't really provide a simple way to suppress calling onResponse of the delegated listener when needed.
|
I left a couple of comments |
|
@imotov should this go into |
|
LGTM |
…or succesfully restored shards to get started This commit ensures that restore operation with wait_for_completion=true doesn't return until all successfully restored shards are started. Before it was returning as soon as restore operation was over, which cause some shards to be unavailable immediately after restore completion. Fixes elastic#8340
imotov
force-pushed
the
issue-8340-wait-for-shards-to-start-at-restore-completion
branch
from
df0cc44
to
1aff863
Compare
clintongormley
changed the title
wait_for_completion:true should wait for succesfully restored shards to get started
imotov
deleted the
issue-8340-wait-for-shards-to-start-at-restore-completion
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that restore operation with wait_for_completion=true doesn't return until all successfully restored shards are started. Before it was returning as soon as restore operation was over, which cause some shards to be unavailable immediately after restore completion.
Fixes #8340