Fix example in logging daily rotate configuration #8550
Closed
+5
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR elastic#8464 come with a bug in the example provided. First, the current log file is not compressed so it should not end with `.gz`. Second, conversion pattern was removing all the log content but was printing only the log date. Then, the current log filename was hardcoded to `elasticsearch` instead of the cluster name.
|
LGTM |
clintongormley
added
>bug
:Core/Infra/Logging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #8464 come with a bug in the example provided.
First, the current log file is not compressed so it should not end with
.gz.Second, conversion pattern was removing all the log content but was printing only the log date.
Then, the current log filename was hardcoded to
elasticsearchinstead of the cluster name.