Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong error messages in MultiMatchQueryParser #8597

Closed
wants to merge 1 commit into from

Conversation

damienalexandre
Copy link
Contributor

There is an issue with the error messages of multi_match:

{
    "multi_match": {
        "query":    "full text search",
        "fields":   [ "title", "body" ]
    }
}

If I do not have any "title" or "body" fields in my mapping, it threw a parse error: No fields specified for match_all query. Which is wrong both ways:

  • There are fields in my query
  • my query is not a "match_all" :)

This PR fix this last issue and a small typo in the doc block.

jpountz pushed a commit that referenced this pull request Nov 21, 2014
Also fix a typo in the comment

Close #8597
jpountz pushed a commit that referenced this pull request Nov 21, 2014
Also fix a typo in the comment

Close #8597
jpountz pushed a commit that referenced this pull request Nov 21, 2014
Also fix a typo in the comment

Close #8597
@jpountz jpountz closed this in 8029545 Nov 21, 2014
@jpountz
Copy link
Contributor

jpountz commented Nov 21, 2014

Merged, thanks!

@clintongormley clintongormley changed the title Fix wrong error messages in MultiMatchQueryParser Query DSL: Fix wrong error messages in MultiMatchQueryParser Nov 25, 2014
@clintongormley clintongormley changed the title Query DSL: Fix wrong error messages in MultiMatchQueryParser Fix wrong error messages in MultiMatchQueryParser Jun 8, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
mute pushed a commit to mute/elasticsearch that referenced this pull request Jul 29, 2015
@clintongormley clintongormley added :Search/Search Search-related issues that do not fall into other categories and removed :Query DSL labels Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug :Search/Search Search-related issues that do not fall into other categories v1.3.6 v1.4.1 v1.5.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants