[TEST] split base settings in ClusterDiscoveryConfiguration between node and transport client #8653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javanna
added
>test
| @@ -33,14 +33,9 @@ | |||
|
|
|||
| public class ClusterDiscoveryConfiguration extends SettingsSource { | |||
|
|
|||
| public static Settings DEFAULT_SETTINGS = ImmutableSettings.settingsBuilder() | |||
There was a problem hiding this comment.
I personally like the fact that those settings were extracted from the code. The name (default) also indicate that these are defaults can be overridden. Don't feel strongly about it though - up to you whether to keep as is.
There was a problem hiding this comment.
I see, I can put the discovery one back as constant but the name default is too generic cause they should get applied only to nodes and not used as base settings for transport client too.
|
LGTM. Left two minor comments. |
|
Updated @bleskes thanks for the review |
|
LGTM |
…ode and transport client The default settings that are currently applied to the transport client are about discovery and gateway, modules that are not even loaded on the transport client. We can now remove the local gateway as it's not the default one anyway. Also, make sure that the discovery setting is only applied to the node, as it is not relevant for transport client. Closes elastic#8653
javanna
force-pushed
the
test/discovery_conf_default_settings
branch
from
57a700f
to
c2f1175
Compare
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Nov 27, 2014
…ode and transport client The default settings that are currently applied to the transport client are about discovery and gateway, modules that are not even loaded on the transport client. We can now remove the local gateway as it's not the default one anyway. Also, make sure that the discovery setting is only applied to the node, as it is not relevant for transport client. Closes elastic#8653
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default settings that are currently applied to the transport client are about discovery and gateway, modules that are not even loaded on the transport client. We can now remove the local gateway as it's the default one anyway. Also, let's make sure that the discovery setting is only applied to the node, as it is not relevant for transport client.