Fix date_histogram issues during a timezone DST switch #8655
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was in the difference between the two responses of the
preTz.getOffset
call. To solve this I only call it once.The behaviour of
roundKey
changed that it is now returning the actual rounded timestamp rounded timestamp offsetted to UTC. The exact opposite is true forvalueForKey
which used to accept the UTC offsetted timestamp but now needs to work on the normal timestamp.The tests for rounding are all passing, including the tests I added where the issue was shown.
Closes #8339
/cc @jpountz