QueryBuilders cleanup (add and deprecate) #8667
Conversation
|
LGTM Would it make sense to delay the removals of textPhrase, ... to 2.0? Hard removals in a minor version can be a bit frustrating from a user perspective even if they have been deprecated for a long time. |
|
I agree we can report the removal to 2.0. |
dadoonet
force-pushed
the
cleanup/7828-querybuilders
branch
from
3d9e9f4
to
f326ade
Compare
|
@jpountz PR updated accordingly. WDYT? |
|
LGTM |
dadoonet
added
:Core/Infra/Transport API
|
@clintongormley I added the |
dadoonet
changed the title
|
@clintongormley I opened a new issue to split properly both operations: deprecate in 1.5 then remove in 2.0. See #8721. So I removed here the |
Some QueryBuilders are missing or have a different naming than the other ones. This patch is applied to branch 1.x and master (elasticsearch 1.5 and 2.0): Added ----- * `templateQuery(...)` * `commonTermsQuery(...)` * `queryStringQuery(...)` * `simpleQueryStringQuery(...)` Deprecated ---------- * `commonTerms(...)` * `queryString(...)` * `simpleQueryString(...)`
dadoonet
force-pushed
the
cleanup/7828-querybuilders
branch
from
f326ade
to
317192b
Compare
You can just add a section about breaking changes in the Java API to the migration page in the main docs, I'd say. |
Related to #8667: Some QueryBuilders have been deprecated in 1.x branches. We removed them in 2.0. Removed ------- * `textPhrase(...)` * `textPhrasePrefix(...)` * `textPhrasePrefixQuery(...)` * `filtered(...)` * `inQuery(...)` * `commonTerms(...)` * `queryString(...)` * `simpleQueryString(...)` Closes #8721.
clintongormley
changed the title
Some QueryBuilders are missing or have a different naming than the other ones.
This patch is applied to branch 1.x and master (elasticsearch 1.5 and 2.0):
Added
templateQuery(...)commonTermsQuery(...)queryStringQuery(...)simpleQueryStringQuery(...)Deprecated
commonTerms(...)queryString(...)simpleQueryString(...)Closes #8721