Switch to write once mode for snapshot metadata files #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imotov
added
:Distributed/Snapshot/Restore
|
w00t! - I will review |
| public void move(String source, String target) throws IOException { | ||
| Path sourcePath = path.resolve(source); | ||
| Path targetPath = path.resolve(target); | ||
| Files.move(sourcePath, targetPath, new CopyOption[]{StandardCopyOption.ATOMIC_MOVE}); |
There was a problem hiding this comment.
I think this can just be
Files.move(sourcePath, targetPath, StandardCopyOption.ATOMIC_MOVE);
|
I really like it. I think we should have a small unittest in |
| @@ -295,19 +304,19 @@ public ClusterState execute(ClusterState currentState) { | |||
| SnapshotMetaData snapshots = metaData.custom(SnapshotMetaData.TYPE); | |||
| ImmutableList.Builder<SnapshotMetaData.Entry> entries = ImmutableList.builder(); | |||
| for (SnapshotMetaData.Entry entry : snapshots.entries()) { | |||
| if (entry.snapshotId().equals(snapshot.snapshotId())) { | |||
| if (entry.snapshotId().equals(entry.snapshotId())) { | |||
There was a problem hiding this comment.
Is that comparison really intended?
|
The more I dig into the snapshot/restore code, the more I like it :) LGTM, left two comments. |
This commit removes creation of in-progress snapshot file and makes creation of the final snapshot file atomic. Fixes elastic#8696
imotov
force-pushed
the
issue-8696-dont-overwrite-snapshot-files
branch
from
19338f5
to
0b024ad
Compare
dadoonet
added a commit
to dadoonet/elasticsearch-cloud-azure
that referenced
this pull request
Jan 30, 2015
This has been added in elasticsearch 2.0.0. See elastic/elasticsearch#8782 Wondering if this PR should be split in two parts: * one that clean the code and which is portable to 1.4, 1.x and master * one that simply add move() method for master branch @imotov WDYT? Closes elastic#49.
dadoonet
added a commit
to elastic/elasticsearch-cloud-azure
that referenced
this pull request
Feb 12, 2015
This has been added in elasticsearch 2.0.0. See elastic/elasticsearch#8782 Wondering if this PR should be split in two parts: * one that clean the code and which is portable to 1.4, 1.x and master * one that simply add move() method for master branch @imotov WDYT? Closes #49.
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Feb 25, 2015
Together with elastic#8782 it should help in the situations simliar to elastic#8887 by adding an ability to get information about currently running snapshot without accessing the repository itself. Closes elastic#8887
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes creation of in-progress snapshot file and makes creation of the final snapshot file atomic.
Fixes #8696