Cleanup LocalGatewayShardsState #8852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kimchy can you please take a look at this you wrote this initially |
s1monw
force-pushed
the
cleanup_lgw_shard_state
branch
2 times, most recently
from
fab04af
to
50c3eb7
Compare
| RoutingNode routingNode = state.readOnlyRoutingNodes().node(state.nodes().localNodeId()); | ||
| final Map<ShardId, ShardStateInfo> newState; | ||
| if (routingNode != null) { | ||
| // our node is not in play yet... |
There was a problem hiding this comment.
this comment was in the original code, I think its misleading, we can remove it
|
LGTM, love the cleanup |
|
cool stuff @kimchy thanks I tried to make it simpler and more efficient. I will add unittests to it and push it!! I will remove the comment too. |
s1monw
force-pushed
the
cleanup_lgw_shard_state
branch
2 times, most recently
from
b201a67
to
63e2bb2
Compare
This commit tries to cleanup LocalGatewayShardsState to be more efficient and easier to understand.
s1monw
force-pushed
the
cleanup_lgw_shard_state
branch
from
63e2bb2
to
5953439
Compare
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tries to cleanup LocalGatewayShardsState to be more efficient
and easier to understand.