Remove circular dependency between IndicesService and IndicesStore #8918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Circular deps are becoming a scary recurring problem (see 0b15859 too)...shall we have a look at some tool that could help us catching those earlier, maybe as part of the build process? |
|
@javanna yeah maybe - I actually wonder if we should be more conservative with interfaces in general this is so overengineered in many places |
| @@ -138,6 +141,8 @@ public StoreRateLimiting rateLimiting() { | |||
| return this.rateLimiting; | |||
| } | |||
|
|
|||
|
|
|||
|
LGTM |
s1monw
force-pushed
the
remove_circular_dep
branch
from
6bd12d9
to
b857a1f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this circular dep. was around forever but it got uncovered yesterday by refactoring the abstractions. I think we should remove it.