Serialize doc values settings for _timestamp #8967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjernst
added
v2.0.0-beta1
v1.5.0
v1.4.2
review
and removed
v1.4.2
v1.5.0
v2.0.0-beta1
labels
| @@ -277,6 +279,9 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws | |||
| if (includeDefaults || fieldType.stored() != Defaults.FIELD_TYPE.stored()) { | |||
There was a problem hiding this comment.
There is also a line above that checks if all options have the default value and returns early. I think we should add the doc-values-related settings to this line as well?
There was a problem hiding this comment.
All metadata mappers have this kind of behaviour which is a pita to maintain... I'm wondering if we could come up with a better solution.
|
Thanks for fixing this, I just left a comment about the detection that all parameters have the default value. |
|
LGTM Thanks for opening this new issue! |
This change fixes _timestamp's serialization method to write out `doc_values` and `doc_values_format`, which could already be set, but would not be written out. closes elastic#8893 closes elastic#8967
rjernst
added a commit
that referenced
this pull request
Jan 12, 2015
rjernst
added a commit
that referenced
this pull request
Jan 12, 2015
rjernst
added a commit
that referenced
this pull request
Jan 12, 2015
rjernst
added a commit
that referenced
this pull request
Jan 12, 2015
clintongormley
added
the
:Search/Mapping
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
This change fixes _timestamp's serialization method to write out `doc_values` and `doc_values_format`, which could already be set, but would not be written out. closes elastic#8893 closes elastic#8967
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change fixes _timestamp's serialization method to write out
doc_valuesanddoc_values_format, which could already be set,but would not be written out.
closes #8893