Reencode transformed result with same xcontent #8974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I originally wrote the transform feature I didn't think that the XContentType of the reencoded source mattered. It actually matters because payloads for the completion suggester are stored and returned exactly as encoded by this XContentType. This revision changes the transform feature from always reencoding with smile to always reencoding with the provided XContentType to support the completion suggester. Closes elastic#8959
clintongormley
added
review
>bug
:Search/Mapping
|
The change looks good, I think it's better to reuse the same xcontent. I'll merge it next week. However this behaviour of the completion suggester looks like a bug to me, maybe we need to fix it separately... |
|
Perfect, thanks for the pointer! |
|
Merged, thanks @nik9000 ! |
clintongormley
changed the title
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I originally wrote the transform feature I didn't think that the
XContentType of the reencoded source mattered. It actually matters because
payloads for the completion suggester are stored and returned exactly
as encoded by this XContentType.
This revision changes the transform feature from always reencoding with smile
to always reencoding with the provided XContentType to support the completion
suggester.
Closes #8959