Installation failed when directories are on different file systems #9011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@s1monw you may be interested in this pr since you made recent change here |
|
We actually need to check that everywhere we're using file move in the code base |
| * @param source source dir | ||
| * @param destination destination dir | ||
| */ | ||
| public static void moveDirectory(Path source, Path destination) throws IOException { |
There was a problem hiding this comment.
can we call this move and maybe just delegate to Files.move without throwing the exception? no need for the caller to know that the source is a directory?
I think we only need to check inside the plugings installer etc. I with we could make it a sep project.... I left a minor comment otherwise LGTM |
tlrx
force-pushed
the
fix/8999
branch
2 times, most recently
from
a270aee
to
a5127d2
Compare
…n different filesystems Plugin installation failed when bin/, conf/ and plugins/ directories are on different file systems. The method File.move() can't be used to move a non-empty directory between different filesystems. I didn't find a simple way to unittest that, even with in-memory filesystems like jimfs or the Lucene test framework. Closes elastic#8999
clintongormley
added
:Core/Infra/Plugins
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plugin installation failed when bin/, conf/ and plugins/ directories are on different file systems. The method File.move() can't be used to move a non-empty directory between different file systems.
I didn't find a simple way to unittest that, even with in-memory filesystems like jimfs or with the Lucene test framework.
Closes #8999