Fix TransportNodesListShardStoreMetaData for custom data paths #9101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -165,7 +165,7 @@ private StoreFilesMetaData listStoreMetaData(ShardId shardId) throws IOException | |||
| if (!storeType.contains("fs")) { | |||
| return new StoreFilesMetaData(false, shardId, ImmutableMap.<String, StoreFileMetaData>of()); | |||
| } | |||
| Path[] shardLocations = nodeEnv.shardPaths(shardId); | |||
There was a problem hiding this comment.
oooh tricky - I wonder how we can make this less error prone?
|
fix LGTM good catch!! |
Cleans up the testReusePeerRecovery test as well The actual fix is in TransportNodesListShardStoreMetaData.java, which needs to use `nodeEnv.shardDataPaths` instead of `nodeEnv.shardPaths`. Due to the difficulty in tracking this down, I've added a lot of additional logging. This also fixes a logging issue in GatewayAllocator
dakrone
force-pushed
the
fix-recovery-reuse-test
branch
from
eda65c7
to
31652a8
Compare
clintongormley
added
>test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleans up the testReusePeerRecovery test as well
The actual fix is in TransportNodesListShardStoreMetaData.java, which
needs to use
nodeEnv.shardDataPathsinstead ofnodeEnv.shardPaths.Due to the difficulty in tracking this down, I've added a lot of
additional logging. This also fixes a logging issue in GatewayAllocator