Don't enable custom data_path for backwards compatibility tests #9119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that this PR is only for the 1.x branch, not master. |
| // Backwards compatibility tests cannot use custom data paths, because | ||
| // some nodes in the cluster may not support the setting, so this is | ||
| // set to false for all backwards integration tests | ||
| return false; |
There was a problem hiding this comment.
can we make this depend on the version so that with future versions that do support it we won't have to go back and enable it? We do this already for other features.
|
LGTM |
dakrone
force-pushed
the
fix-bwc-custom-path-tests
branch
from
77d3a4e
to
782a4df
Compare
Since some nodes in the test may not support the feature, it should be disabled in the random tests for all the BackwardsCompatIntegrationTests This also adds a check in `MetaDataCreateIndexService` for all nodes to be at least 1.5.0+ when creating an index with a custom data_path. It will only work if the 1.5.0 node is the master in the cluster, but it is better protection than nothing.
dakrone
force-pushed
the
fix-bwc-custom-path-tests
branch
from
782a4df
to
47f50e4
Compare
clintongormley
added
>test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since some nodes in the test may not support the feature, it should be
disabled in the random tests for all the BackwardsCompatIntegrationTests
This also adds a check in
MetaDataCreateIndexServicefor all nodes tobe at least 1.5.0+ when creating an index with a custom data_path. It
will only work if the 1.5.0 node is the master in the cluster, but it is
better protection than nothing.