Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recovery: RecoveryTarget does not fsync the right file name #9144

Closed
jpountz opened this issue Jan 5, 2015 · 6 comments
Closed

Recovery: RecoveryTarget does not fsync the right file name #9144

jpountz opened this issue Jan 5, 2015 · 6 comments
Labels
>bug

Comments

@jpountz
Copy link
Contributor

jpountz commented Jan 5, 2015

This class reads the file from the network into a temporary file, and then fsyncs the original file name - which does nothing since the file does not exist and FSDirectory silently ignores syncs on unknown files (fixed in https://issues.apache.org/jira/browse/LUCENE-6150).
@jpountz jpountz added the >bug label Jan 5, 2015
jpountz added a commit to jpountz/elasticsearch that referenced this issue Jan 5, 2015
@jpountz
Recovery: RecoveryTarget does not fsync the right file name.
52e761f 
Close elastic#9144
@uschindler
Copy link
Contributor

I fixed this in Lucene 5 and trunk through LUCENE-6150.

@uschindler
Copy link
Contributor

Ah you mentioned this already!

@jpountz
Copy link
Contributor Author

jpountz commented Jan 5, 2015

Yes, I found about it while upgrading to a more recent Lucene 5 snapshot :) This is much less trappy now!

@s1monw
Copy link
Contributor

s1monw commented Jan 5, 2015

grrrr....!!!

@jpountz jpountz closed this as completed in cd04851 Jan 6, 2015
@jpountz
Copy link
Contributor Author

jpountz commented Jan 6, 2015

For the record, this bug was introduced in #8092 which is only on master and 1.x so the bug has not been released.

jpountz added a commit that referenced this issue Jan 6, 2015
@jpountz
Recovery: RecoveryTarget does not fsync the right file name.
090c977 
Close #9144
@jpountz jpountz changed the title Recovery: RecoveryTarget does not recover the right file name Recovery: RecoveryTarget does not fsync the right file name Jan 6, 2015
@uschindler
Copy link
Contributor

Hehe, it was useful to fix the staleFiles mess! Thanks for confirmation. I had exectly this problem in mind when looking into this (in addition to the onIndexOutputClosed callback, that made the FSDirectory API crazy).

Maybe leave a comment on the Lucene issue to give us feedback that it was already useful :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jpountz @s1monw @uschindler