Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 0.20.x index. #9146

Closed
wants to merge 3 commits into from
Closed

Add 0.20.x index. #9146

wants to merge 3 commits into from

Conversation

rmuir
Copy link
Contributor

@rmuir rmuir commented Jan 5, 2015

we don't have any in the 1.x branch. Here is one i made.

Note: IMO this test should fail, but it does not. I think there are
more problems in general (real code paths for recovery are not
actually being executed in assertNewReplicasWork, etc). But we need
to start with something.

we don't have any in the 1.x branch. Here is one i made.

Note: IMO this test should fail, but it does not. I think there are
more problems in general (real code paths for recovery are not
actually being executed in assertNewReplicasWork, etc). But we need
to start with something.
@rmuir
Copy link
Contributor Author

rmuir commented Jan 5, 2015

Note: i am also worried about older indexes too. I am unsure if we are just replaying old transaction logs for them because i hit race conditions in the python.

@rmuir
Copy link
Contributor Author

rmuir commented Jan 5, 2015

OK, the last of the bugs were caused by builder APIs in the test.

I would like to commit this, as I have a failing test now for #9140

0.20.6 is temporarily disabled until then.

ensureGreen("test"); // TODO: what is the proper way to wait for new replicas to recover?

client().admin().indices().prepareUpdateSettings("test").setSettings(ImmutableSettings.builder()
.put("number_of_replicas", 0)
.build());
.put("number_of_replicas", 0))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can put these into assertAcked(client().admin().indices().prepareUpdateSettings("test")..... to make sure this doesn't happen again

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

where is assertAcked? Its not defined by this test or any superclasses.

@s1monw
Copy link
Contributor

s1monw commented Jan 5, 2015

left one comment - good catch!

@rmuir rmuir added >test Issues or PRs that are addressing/adding tests v2.0.0-beta1 v1.5.0 v1.4.3 v1.3.8 and removed v1.3.8 v1.4.3 labels Jan 5, 2015
@rmuir
Copy link
Contributor Author

rmuir commented Jan 5, 2015

I pushed to master and 1.x, its the only places that currently have the static-index-bwcompat tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>test Issues or PRs that are addressing/adding tests v1.5.0 v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants