Reduce the size of the search thread pool. #9165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +114,7 @@ public ThreadPool(Settings settings, @Nullable NodeSettingsService nodeSettingsS | |||
| .put(Names.INDEX, settingsBuilder().put("type", "fixed").put("size", availableProcessors).put("queue_size", 200).build()) | |||
| .put(Names.BULK, settingsBuilder().put("type", "fixed").put("size", availableProcessors).put("queue_size", 50).build()) | |||
| .put(Names.GET, settingsBuilder().put("type", "fixed").put("size", availableProcessors).put("queue_size", 1000).build()) | |||
| .put(Names.SEARCH, settingsBuilder().put("type", "fixed").put("size", availableProcessors * 3).put("queue_size", 1000).build()) | |||
| .put(Names.SEARCH, settingsBuilder().put("type", "fixed").put("size", availableProcessors * 3 / 2 + 1).put("queue_size", 1000).build()) | |||
There was a problem hiding this comment.
can we use this ((availableProcessors * 3) / 2) + 1 even though it's equivalent
|
I think it's good - left one comment |
Follow-up of elastic#9135. We initially decreased the stack size because it would end up a lot of memory when there are many threads. But we also have some thread pools that may be oversized, in particular the search thread pool. This commit proposes to decrease the default search thread pool size from `3 * num_procs` to `3 * num_procs / 2 + 1`. This is large enough to be sure that we can use all the machine resources even with a search-only work load but not too large in order to not consume too much memory because of the stack size and thread locals.
jpountz
force-pushed
the
enhancement/reduce_search_pool_size
branch
from
96542f4
to
08388e0
Compare
|
Applied the suggested change, will push soon. |
jpountz
added a commit
that referenced
this pull request
Apr 7, 2015
…size Internal: reduce the size of the search thread pool.
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #9135. We initially decreased the stack size because it would end
up a lot of memory when there are many threads. But we also have some thread
pools that may be oversized, in particular the search thread pool.
This commit proposes to decrease the default search thread pool size from
3 * num_procsto3 * num_procs / 2 + 1. This is large enough to be surethat we can use all the machine resources even with a search-only work load
but not too large in order to not consume too much memory because of the stack
size and thread locals.