Fold engine into IndexShard #9181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -23,6 +23,7 @@ | |||
| import org.elasticsearch.common.logging.Loggers; | |||
| import org.elasticsearch.common.settings.Settings; | |||
| import org.elasticsearch.index.settings.IndexSettings; | |||
| import org.elasticsearch.indices.cluster.IndicesClusterStateService; | |||
There was a problem hiding this comment.
Extra unneeded additions in this file?
|
LGTM, this is a nice simplification! |
| private long gcDeletesInMillis = DEFAULT_GC_DELETES.millis(); | ||
|
|
||
| private volatile boolean enableGcDeletes = true; | ||
| private volatile String codecName = DEFAUTL_CODEC; |
|
Left some comments, but I like the simplification a lot! |
|
I iterated here a bit and added all kinds of cleanups on the engine. I also added documentation to the new EngineConfig and removed unused methods. I think it's ready, unless anybody objects I will push soon |
|
LGTM |
This commit removes most of the Engine abstractions and removes Engine exposure via dependency injection. It also removes the Holder abstraction and makes the engine itself start at constrcution time. It removes the start method from the engine entire which means no engine instances exists until it's started. There is also no way to stop the engine to restart, it needs to be an entire new Engine
|
I pushed this to 1.x as well |
clintongormley
changed the title
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes most of the Engine abstractions and removes
Engine exposure via dependency injection. It also removes the Holder
abstraction and makes the engine itself start at constrcution time.
It removes the start method from the engine entire which means no engine
instances exists until it's started. There is also no way to stop the
engine to restart, it needs to be an entire new Engine