Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allow_type_wrapper setting #9185

Merged
merged 1 commit into from Jan 8, 2015

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Jan 7, 2015

Before Elasticsearch 1.0, the type was allowed to be passed as the root
element when uploading a document. However, this was ambiguous if the
mappings also contained a field with the same name as the type. The
behavior was changed in 1.0 to not allow this, but a setting was added
for backwards compatibility. This change removes the setting for 2.0.

@jpountz
Copy link
Contributor

jpountz commented Jan 8, 2015

LGTM

Before Elasticsearch 1.0, the type was allowed to be passed as the root
element when uploading a document.  However, this was ambiguous if the
mappings also contained a field with the same name as the type.  The
behavior was changed in 1.0 to not allow this, but a setting was added
for backwards compatibility.  This change removes the setting for 2.0.
@rjernst rjernst merged commit 060f963 into elastic:master Jan 8, 2015
@rjernst rjernst added :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1 >breaking labels Jan 9, 2015
@rjernst rjernst deleted the remove/allow_type_wrapper branch January 21, 2015 23:22
@clintongormley clintongormley changed the title Mappings: Remove allow_type_wrapper setting Remove allow_type_wrapper setting Jun 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>breaking :Search/Mapping Index mappings, including merging and defining field types v2.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants