Simplify Engine construction and ref counting #9211
Merged
+96
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this relates to #9181 |
|
LGTM |
Today the internal engine closes itself it the engine hits an exception it can not recover from. This complicates a lot of refcounting issues if such an exception happens during engine creation. This commit only markes the engine as failed and let the user close it once the exception bubbles up. Additionally it rolls back the indexwriter to prevent any changes after the engine is failed.
s1monw
force-pushed
the
simplify_engine_failure
branch
from
ef3b89d
to
d2277d7
Compare
|
I pushed this to 1.x as well |
bleskes
added a commit
to bleskes/elasticsearch
that referenced
this pull request
Jan 30, 2015
…ring COMMIT_TRANSLOG flush This was fixed as part of elastic#9211
clintongormley
changed the title
mute
pushed a commit
to mute/elasticsearch
that referenced
this pull request
Jul 29, 2015
…ring COMMIT_TRANSLOG flush This was fixed as part of elastic#9211 Closes elastic#9501
clintongormley
added
:Distributed/Distributed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Today the internal engine closes itself it the engine hits an exception
it can not recover from. This complicates a lot of refcounting issues
if such an exception happens during engine creation. This commit
only markes the engine as failed and let the user close it once the exception
bubbles up. Additionally it rolls back the indexwriter to prevent any changes after
the engine is failed.