Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging on upgrade API #9227

Closed
ppf2 opened this issue Jan 9, 2015 · 1 comment · Fixed by #9229
Closed

Logging on upgrade API #9227

ppf2 opened this issue Jan 9, 2015 · 1 comment · Fixed by #9229

Comments

@ppf2
Copy link
Member

ppf2 commented Jan 9, 2015

Currently, when you run the upgrade API, there is no logging to indicate when it started, what it is doing (not even at higher logging levels like DEBUG) and when it has completed. It will be nice to provide some logging for this api.

@rjernst
Copy link
Member

rjernst commented Jan 9, 2015

It looks like we already have some minimal logging in the merge policy that does the upgrade. At DEBUG level, you should see messages like Adding segment XYZ to be upgraded.

I will add a message for each index/shard when it is beginning the upgrade. However, when it ends is a little ambiguous. The current code calls waitForMerges (through a hack, because this method is no longer public on IndexWriter). Really what we want is to wait for the chain of findForcedMerges to complete. I can add a log message when we are "done" here, but it is not necessarily correct (could log after the real upgrade finished).

rjernst added a commit to rjernst/elasticsearch that referenced this issue Jan 12, 2015
rjernst added a commit that referenced this issue Jan 12, 2015
rjernst added a commit that referenced this issue Jan 12, 2015
mute pushed a commit to mute/elasticsearch that referenced this issue Jul 29, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants