Package private getters to become public if there have corresponding public setters #9273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponding public setters Some of our Java API requests have public setters but their corresponding getters are package private only. This commit makes those getters public as well. Closes elastic#9273
javanna
force-pushed
the
enhancement/requests_public_getters
branch
from
dcf1180
to
4bdc89f
Compare
|
LGTM |
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jan 13, 2015
…esponding public setters Some of our Java API requests have public setters but their corresponding getters are package private only. This commit makes those getters public as well. Closes elastic#9273
clintongormley
added
:Core/Infra/Transport API
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of our Java API requests have public setters but their corresponding getters are package private only, which doesn't make much sense as anybody can set their values but it is not possible to read those same values.
This PR addresses this by making existing package private getters public when they have a corresponding public setter.