Relax restrictions on filesystem size reporting in DiskUsage #9283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dakrone
force-pushed
the
fix-9260
branch
3 times, most recently
from
6a9bd9a
to
1bac587
Compare
| @@ -31,20 +31,30 @@ | |||
| final long totalBytes; | |||
| final long freeBytes; | |||
|
|
|||
| /** | |||
| * Create a new DiskUsage, if {@code totalBytes} is 0, 1 is used to avoid | |||
There was a problem hiding this comment.
I think this comment is no longer true?
|
LGTM. Left some cosmetic comments , mostly around comments to explain the edge cases this covers. |
Apparently some filesystems such as ZFS and occasionally NTFS can report filesystem usages that are negative, or above the maximum total size of the filesystem. This relaxes the constraints on `DiskUsage` so that an exception is not thrown. If 0 is passed as the totalBytes, `.getFreeDiskAsPercentage()` will always return 100.0% free (to ensure the disk threshold decider fails open) Fixes elastic#9249 Relates to elastic#9260
clintongormley
changed the title
clintongormley
added
:Data Management/Stats
clintongormley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently some filesystems such as ZFS and occasionally NTFS can report
filesystem usages that are negative, or above the maximum total size of
the filesystem. This relaxes the constraints on
DiskUsageso that anexception is not thrown.
If 0 is passed as the totalBytes, 1 is used to avoid a division-by-zero
error.
Fixes #9249
Relates to #9260